Merged
Conversation
Since a while we've had a boolean option that determines if the kickstart file we write for certain image types ends up in the root of an ISO or in the `/usr/share/anaconda/interactive-defaults.ks` path. This changes things only for the `minimal-installer` in Fedora as all other installer adjacent image types had this set to `true`. I've tested the `minimal-installer` to still function. Historically we introduced the `minimal-installer` (then called `image-installer`) to test the Anaconda webui. At that point in time the webui didn't support any kickstarts excepts the one in `interactive-defaults.ks`. Right now it only leads to confusion. I'll likely re-introduce the ability to modify the kickstart path(s) through the installer configs in the image definitions at a later point in time if we need it instead of having a boolean toggle. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
supakeen
force-pushed
the
drop-isorootkickstart
branch
from
d6a6a6c to
126bef5
Compare
thozza
approved these changes
Aug 21, 2025
| assert.Contains(t, mfs, fmt.Sprintf(`"inst.stage2=hd:LABEL=%s"`, isolabel)) | ||
| assert.Contains(t, mfs, fmt.Sprintf("%q", osbuild.KickstartPathInteractiveDefaults)) | ||
| assert.NotContains(t, mfs, "osbuild.ks") // no mention of the default (custom) value | ||
| assert.Contains(t, mfs, fmt.Sprintf(`"inst.ks=hd:LABEL=%s:/osbuild.ks"`, isolabel)) |
Member
There was a problem hiding this comment.
Nitpick: Shouldn't the unit test consider img.Kickstart.Path value? 🤔
Member
Author
I'll do that as part of the entire "InteractiveDefaults" cleanup! |
croissanne
added a commit
to croissanne/osbuild-composer
that referenced
this pull request
Aug 21, 2025
Changes with 0.178.0 ---------------- - Update osbuild dependency commit ID to latest (osbuild/images#1763) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger - many: drop `ISORootKickstart` (osbuild/images#1769) - Author: Simon de Vlieger, Reviewers: Brian C. Lane, Tomáš Hozza - many: drop the workload.Workload type entirely (osbuild/images#1770) - Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza - platform: drop hardcoded platforms and rename PlatformConf (osbuild/images#1739) - Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger - rhel: fix openscap profile allowlists (HMS-9095) (osbuild/images#1778) - Author: Sanne Raymaekers, Reviewers: Michael Vogt, Simon de Vlieger — Somewhere on the Internet, 2025-08-21
croissanne
added a commit
to osbuild/osbuild-composer
that referenced
this pull request
Aug 21, 2025
Changes with 0.178.0 ---------------- - Update osbuild dependency commit ID to latest (osbuild/images#1763) - Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger - many: drop `ISORootKickstart` (osbuild/images#1769) - Author: Simon de Vlieger, Reviewers: Brian C. Lane, Tomáš Hozza - many: drop the workload.Workload type entirely (osbuild/images#1770) - Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza - platform: drop hardcoded platforms and rename PlatformConf (osbuild/images#1739) - Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger - rhel: fix openscap profile allowlists (HMS-9095) (osbuild/images#1778) - Author: Sanne Raymaekers, Reviewers: Michael Vogt, Simon de Vlieger — Somewhere on the Internet, 2025-08-21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since a while we've had a boolean option that determines if the kickstart file we write for certain image types ends up in the root of an ISO or in the
/usr/share/anaconda/interactive-defaults.kspath.This changes things only for the
minimal-installerin Fedora as all other installer adjacent image types had this set totrue.I've tested the
minimal-installerto still function.Historically we introduced the
minimal-installer(then calledimage-installer) to test the Anaconda webui. At that point in time the webui didn't support any kickstarts excepts the one ininteractive-defaults.ks.Right now it only leads to confusion. I'll likely re-introduce the ability to modify the kickstart path(s) through the installer configs in the image definitions at a later point in time if we need it instead of having a boolean toggle.
Note that with this change the
InteractiveDefaultsname no longer really makes any sense; I might add a commit or two to rename it once I think about better names but I'll likely do that in a follow-up as it's all quite intertwined with eachother.Note that the
minimal-installerimage type for which checksums change isn't one that we ship or publish anywhere.